[DoctrineBridge] Added support for boolean value in UniqueEntity

[ottaviano]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR	symfony/symfony-docs#10404

Hi 👋,
little feature to allow to use UniqueEntityValidator with boolean type field (ex: Entity::enabled property) with ignoreFalse constraint option for allowing many entities with false value.

[linaori]

Thanks for proposing this feature! As I don't see a related ticket, can you explain why you need this feature and what use-cases this would support? That would greatly help the core team to decide whether or not this feature is right for Symfony or perhaps if another solution would be desired.

[ottaviano]

@linaori, for example, I have a Menu entity with the default boolean property, and I would like to allow to create only one menu with default=true value and many entities with default=false value. The same thing as with ignoreNull option of the UniqueEntity constraint.

[ottaviano]

Branch rebased.

[xabbuh]

I am not convinced that limiting this feature to false is desirable (the special handling for null is due to how null is handled by databases when using unique constraints there). IMO this feature would be better suited if you were allowed to give values for which there must not be more than one entry (could for example as well be the string enabled instead of a boolean true).

[ottaviano]

hello @xabbuh, thank you for your review 👍
hm, I think it's a good idea, I'll try to do it

[OskarStark]

Hey @ottaviano 👋

Do you find some time to finish this PR?

[fabpot]

I'm going to close this PR as there is no more activity nor feedback. @ottaviano Feel free to reopen it whenever you have time to finish it (if you want to).

[ottaviano]

Hi @OskarStark & @fabpot, sorry for the silence, I did not have access to my emails during the holidays.
I completely forgot about this PR 😓
ok for closing it, and if I find time to finish, I will reopen it

[fabpot]

@ottaviano No worries. Reopen it whenever you have time.