[Console] Update the table helper page #20941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
changed the title
alamirault
reviewed
May 6, 2025
Comment on lines
-192
to
+216
| This code results in: | ||
| This outputs: |
There was a problem hiding this comment.
I saw we don't have same wording for result in this file, should we also update them ?
This outputs:
The output of this command will be:
This generates:
This will display the following table in the terminal:
This will display:
Nothing for Adding Table Titles section
There was a problem hiding this comment.
Nice catch, streamlining those things would be nice.
WDYT @symfony/docs ?
There was a problem hiding this comment.
Good catch! I made all this consistent and used This outputs because it's very concise and easy to understand. Thanks!
alamirault
approved these changes
May 6, 2025
javiereguiluz
force-pushed
the
table_helper
branch
from
8787763 to
b4ac701
Compare
javiereguiluz
added a commit
that referenced
this pull request
May 8, 2025
…reguiluz) This PR was squashed before being merged into the 7.3 branch. Discussion ---------- [Console] Update some contents of the Tree helper This updates the Tree helper explanation about custom styles to match the same structure as in the Table helper page (see #20941). It also adds a better example of how to create trees programmatically. Commits ------- 2727dde [Console] Update some contents of the Tree helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page about the Table helper is like this: https://symfony.com/doc/6.4/components/console/helpers/table.html
The sidebar looks empty. I think it's missing some headers to better structure the contents into sections.