Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect all deprecations with lint:twig command #20861

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

RisingSunLight42
Copy link
Contributor

@RisingSunLight42 RisingSunLight42 commented Apr 6, 2025

This PR fix #20840 by tweaking the docs to precise only the first deprecation found will be outputed by the command.

It's my first PR, I hope everything is fine, don't hesitate to notify me of any incorrect wording / style, or anything else. I'd be happy to learn how to contribute better for my future contributions!

fixes #20840

@carsonbot carsonbot added this to the 6.4 milestone Apr 6, 2025
@carsonbot carsonbot changed the title [TwigBridge] Collect all deprecations with lint:twig command Collect all deprecations with lint:twig command Apr 6, 2025
@javiereguiluz javiereguiluz merged commit ba43650 into symfony:6.4 Apr 7, 2025
3 checks passed
@javiereguiluz
Copy link
Member

@RisingSunLight42 thanks a lot for this ... and congrats on your first Symfony Docs contribution 🎉

You did it great. While merging we did some minor reword to match the style of the rest of the docs, but your contribution was more than correct. Thanks!

@javiereguiluz
Copy link
Member

We merged this to all upper branches ... and changed this in 7.3 branch. See b5efbcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants