[Encore] [Frontend] Correct "Removes comments from CSS" comparison #20620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
front-end-toolings-adjustments
branch
from
e3926d4 to
bed785d
Compare
carsonbot
changed the title
|
Thanks Hugo! About your question, I know it seems an "unfair" comparison, but at the same time, I think it's important to highlight this difference. With AssetMapper, you install and update packages with AssetMapper utilities ... whereas with Webpack Encore you cannot do that and need external utilities. It's true that AssetMApper doesn't provide a full-featured package-manager, but it's enough for many use cases. |
|
Alright, thanks for the clarification Javier! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Following internal discussions about Encore, I came across this page and found incorrect information, Encore can remove comments from CSS by configuring the
CssMinimizerPlugin, included with Encore.On another note, I don't really understand the sentence
Can update 3rd party packages. It looks like a comparaison betweenimportmap:requireand something that is not a Node.js package manager... right? isn't this comparison biased?Thanks!