-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TwigBridge] Collect all deprecations with lint:twig
command
#20840
Comments
Unsure if any addition to the doc could be made? It's already mentionned in linting twig templates. It was already implied in the docs that it was listing all deprecations, so maybe instead of changing the doc for 7.3, change the doc of previous versions to add a notice that it will list the first deprecation encountered only? |
I like your plan ... mention in 6.4 and 7.2 that only the first deprecation is shown. Then, in 7.3, remove that and add a The contribution only needs to do this change in 6.4 and we'll merge this change in the other branches. @RisingSunLight42 would you be able to send a pull request with this change? Thanks! |
Yes I can! Just to be sure, I do a PR on 6.4 with the mention of only the first deprecation is shown, and then you will take care of the rest for the other versions? Sorry If I'm asking something that seems obvious, I just want to not mess up |
Yes, what you said is what needs to be done. And don't worry about asking anything you want. We're here to help everybody. Thanks! |
We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.
To fix this issue, please create a PR against the 7.3 branch in the symfony-docs repository.
Thank you! 😃
The text was updated successfully, but these errors were encountered: