-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[league/oauth2-server-bundle] Add v0.11 recipe #1397
Conversation
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. league/oauth2-server-bundle0.4 vs 0.11diff --git a/league/oauth2-server-bundle/0.4/config/routes/league_oauth2_server.yaml b/league/oauth2-server-bundle/0.11/config/routes/league_oauth2_server.yaml
index b874e00..38a4d1b 100644
--- a/league/oauth2-server-bundle/0.4/config/routes/league_oauth2_server.yaml
+++ b/league/oauth2-server-bundle/0.11/config/routes/league_oauth2_server.yaml
@@ -1,3 +1,3 @@
-oauth2_server:
- resource: '@LeagueOAuth2ServerBundle/Resources/config/routes.php'
+league_oauth2_server:
+ resource: '@LeagueOAuth2ServerBundle/config/routes.php'
type: php
diff --git a/league/oauth2-server-bundle/0.4/manifest.json b/league/oauth2-server-bundle/0.11/manifest.json
index 71be019..ee510d4 100644
--- a/league/oauth2-server-bundle/0.4/manifest.json
+++ b/league/oauth2-server-bundle/0.11/manifest.json
@@ -11,8 +11,5 @@
"OAUTH_PASSPHRASE": "%generate(secret)%",
"OAUTH_ENCRYPTION_KEY": "%generate(secret)%"
},
- "gitignore": [
- "/%CONFIG_DIR%/jwt/*.pem"
- ],
"aliases": ["oauth2-server", "oauth-server"]
}
diff --git a/league/oauth2-server-bundle/0.4/post-install.txt b/league/oauth2-server-bundle/0.11/post-install.txt
index 2976520..1eba7a5 100644
--- a/league/oauth2-server-bundle/0.4/post-install.txt
+++ b/league/oauth2-server-bundle/0.11/post-install.txt
@@ -1,5 +1,5 @@
1. Provide a key pair
- * Generate a private/public key pair at the locations defined in your .env file, using the value of the OAUTH_PASSPHRASE as passphrase: https://oauth2.thephpleague.com/installation/#generating-public-and-private-keys
+ * Generate a private/public key pair by running php bin/console league:oauth2-server:generate-keypair
2. Update the database schema
* Update your database schema so that bundle entities can be managed by Doctrine |
league/oauth2-server-bundle/0.11/config/routes/league_oauth2_server.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Antonio J. García Lagar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
/cc @ajgarlag