[WIP] Add recipe for friendsofsymfony/user-bundle #210
Conversation
devtronic
commented
Dec 17, 2017
devtronic
commented
| Q | A |
|---|---|
| License | MIT |
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Pull request does not pass validation.
| @@ -0,0 +1,8 @@ | |||
| # Read the documentation: https://symfony.com/doc/master/bundles/FOSRestBundle/index.html | |||
| fos_user: ~ | |||
There was a problem hiding this comment.
"fos_user" should be removed as it is empty
ghost
deployed
to
| # Read the documentation: https://symfony.com/doc/master/bundles/FOSUserBundle/index.html | ||
| fos_user: | ||
| # db_driver: orm # other valid values are 'mongodb' and 'couchdb' | ||
| firewall_name: main |
There was a problem hiding this comment.
Instead, it's better IMO to directly uncomment db_driver, firewall_name and user_class in the recipe as they are all mandatory anyway in the bundle.
There was a problem hiding this comment.
Thanks, you're right. I changed the config in e129d94
| "config/": "%CONFIG_DIR%/" | ||
| }, | ||
| "env": { | ||
| "MAILER_USER": "" |
There was a problem hiding this comment.
I think MAILER_USER is inconsistent with possible configuration value. I think MAILER_SENDER would probably be more appropriate. A "user" option is more to configure the mailer with a user.
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Pull request does not pass validation.
|
|
||
| services: | ||
| validator.builder: | ||
| class: Symfony\Component\Config\Definition\Builder\ValidationBuilder No newline at end of file |
| sender_name: "%env(MAILER_USER)%" | ||
|
|
||
| services: | ||
| validator.builder: |
There was a problem hiding this comment.
That's absolutely not how the recipe should work. Instead, the package itself should require the Symfony package that installs this service, which is symfony/validator in this case.
This is a problem from the FOSUserBundle side that should be fixed before a recipe can be created.
There was a problem hiding this comment.
This service should be removed. You use add symfony/validator to the dependencies section in your composer.json.
|
FYI. This is a duplicate of #270. |
4 participants
