Skip to content

Re-add fixed APP_SECRET value #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Re-add fixed APP_SECRET value #1579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env.local.demo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# This variable is for the demo app only!
# See https://symfony.com/doc/current/reference/configuration/framework.html#configuration-framework-secret
APP_SECRET=not-a-secret--read-the-doc!
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
},
"scripts": {
"auto-scripts": {
"-r \"@rename('.env.local.demo', '.env.local');\"": "php-script",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could overwrite existing config if a user already created or edited their own .env.local file. Shouldn't we account for that?

That's why I opted for only generating a APP_SECRET on new installs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this applies: the command is run first. There will be no .env.local to override.

generating a APP_SECRET on new installs

I think that's exactly what this achieves, with support for git-cloned demo apps also.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @rosier

  1. I install the project
  2. I configure SYMFONY_IDE to enhance my DX
  3. I run composer up to try new symfony feature
  4. I have lost my SYMFONY_IDE env var

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I install the project

then done, the command will have created the .env.local file and won't touch it again

Copy link
Member

@stof stof Jun 2, 2025 •
edited by lyrixx
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not true. auto-scripts are run each time you run composer update or composer install.

And renaming the file instead of copying it will be a mess for contributors, as it means the git working directory is in a dirty state.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once .env.local.demo is renamed, the second run will do nothing so I'm not sure what's not true?

About the git state, that's right. I don't think this is a blocker, especially as we tried many alternatives and this looks like the most effective in a oneliner.

On the flip side, the git diff will give users an opportunity to read about the concern.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about adding it in the post-install-cmd section only?

"cache:clear": "symfony-cmd",
"assets:install %PUBLIC_DIR%": "symfony-cmd",
"importmap:install": "symfony-cmd",
Expand Down