Merge branch '7.1' into 7.2

* 7.1: do not access typed property before initialization do not access typed properties before initialization Fix typo in deprecation message Symfony 5.4 LTS will get security fixes until Feb 2029 thanks to Ibexa' sponsoring Fix #53037
symfony · Oct 22, 2024 · d748fcb · d748fcb
2 parents edbb1d0 + af38cce
commit d748fcb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/AbstractBrowser.php b/AbstractBrowser.php
@@ -554,7 +554,7 @@ public function reload(): Crawler
      */
     public function followRedirect(): Crawler
     {
-        if (!$this->redirect) {
+        if (!isset($this->redirect)) {
             throw new LogicException('The request was not redirected.');
         }
 

diff --git a/Tests/AbstractBrowserTest.php b/Tests/AbstractBrowserTest.php
@@ -15,6 +15,7 @@
 use Symfony\Component\BrowserKit\CookieJar;
 use Symfony\Component\BrowserKit\Exception\BadMethodCallException;
 use Symfony\Component\BrowserKit\Exception\InvalidArgumentException;
+use Symfony\Component\BrowserKit\Exception\LogicException;
 use Symfony\Component\BrowserKit\History;
 use Symfony\Component\BrowserKit\Request;
 use Symfony\Component\BrowserKit\Response;
@@ -889,4 +890,14 @@ public function testInternalRequestNull()
 
         $client->getInternalRequest();
     }
+
+    public function testFollowRedirectWithoutRequest()
+    {
+        $browser = $this->getBrowser();
+
+        $this->expectException(LogicException::class);
+        $this->expectExceptionMessage('The request was not redirected.');
+
+        $browser->followRedirect();
+    }
 }