[BrowserKit] Use strict comparison when possible

symfony · May 6, 2022 · b839cef · b839cef
1 parent 115bad0
commit b839cef
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/AbstractBrowser.php b/AbstractBrowser.php
@@ -87,7 +87,7 @@ public function isFollowingRedirects(): bool
     public function setMaxRedirects(int $maxRedirects)
     {
         $this->maxRedirects = $maxRedirects < 0 ? -1 : $maxRedirects;
-        $this->followRedirects = -1 != $this->maxRedirects;
+        $this->followRedirects = -1 !== $this->maxRedirects;
     }
 
     /**
@@ -354,7 +354,7 @@ public function request(string $method, string $uri, array $parameters = [], arr
             $server['HTTP_HOST'] = $this->extractHost($uri);
         }
 
-        $server['HTTPS'] = 'https' == parse_url($uri, \PHP_URL_SCHEME);
+        $server['HTTPS'] = 'https' === parse_url($uri, \PHP_URL_SCHEME);
 
         $this->internalRequest = new Request($uri, $method, $parameters, $files, $this->cookieJar->allValues($uri), $server, $content);
 
@@ -623,7 +623,7 @@ protected function getAbsoluteUri(string $uri): string
         }
 
         // anchor or query string parameters?
-        if (!$uri || '#' == $uri[0] || '?' == $uri[0]) {
+        if (!$uri || '#' === $uri[0] || '?' === $uri[0]) {
             return preg_replace('/[#?].*?$/', '', $currentUri).$uri;
         }
 
@@ -654,7 +654,7 @@ private function updateServerFromUri(array $server, string $uri): array
     {
         $server['HTTP_HOST'] = $this->extractHost($uri);
         $scheme = parse_url($uri, \PHP_URL_SCHEME);
-        $server['HTTPS'] = null === $scheme ? $server['HTTPS'] : 'https' == $scheme;
+        $server['HTTPS'] = null === $scheme ? $server['HTTPS'] : 'https' === $scheme;
         unset($server['HTTP_IF_NONE_MATCH'], $server['HTTP_IF_MODIFIED_SINCE']);
 
         return $server;

diff --git a/Cookie.php b/Cookie.php
@@ -157,7 +157,7 @@ public static function fromString(string $cookie, string $url = null): static
 
             if ('secure' === strtolower($part)) {
                 // Ignore the secure flag if the original URI is not given or is not HTTPS
-                if (!$url || !isset($urlParts['scheme']) || 'https' != $urlParts['scheme']) {
+                if (!$url || !isset($urlParts['scheme']) || 'https' !== $urlParts['scheme']) {
                     continue;
                 }
 

diff --git a/CookieJar.php b/CookieJar.php
@@ -180,7 +180,7 @@ public function allValues(string $uri, bool $returnsRawValue = false): array
                 }
 
                 foreach ($namedCookies as $cookie) {
-                    if ($cookie->isSecure() && 'https' != $parts['scheme']) {
+                    if ($cookie->isSecure() && 'https' !== $parts['scheme']) {
                         continue;
                     }
 

diff --git a/History.php b/History.php
@@ -45,7 +45,7 @@ public function add(Request $request)
      */
     public function isEmpty(): bool
     {
-        return 0 == \count($this->stack);
+        return 0 === \count($this->stack);
     }
 
     /**
@@ -83,7 +83,7 @@ public function forward(): Request
      */
     public function current(): Request
     {
-        if (-1 == $this->position) {
+        if (-1 === $this->position) {
             throw new \LogicException('The page history is empty.');
         }