[CI] Wait for Docker services to be healthy before running tests #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Dec 15, 2025
| working-directory: examples | ||
| run: docker compose up -d | ||
|
|
||
| - name: Wait for services to be healthy |
Contributor
There was a problem hiding this comment.
@Guikingone if this works, we can get rid of the 10sec sleep?
Contributor
There was a problem hiding this comment.
Yes.
I'm not sure it will solve the Opensearch, when launched locally, it can be considered as "healthy" and not be fully operational, to test on this one to ensure that we're not missing it.
Contributor
Author
There was a problem hiding this comment.
@Guikingone I am looking into OpenSearch and ElasticSearch locally in more detail. You are right that this does not remove the OS issue for now, but from my local work, it was a necessary step to rule out that the container was up an running before trying out the tests.
Member
|
had the same issue and went lazy on it since you're on it ... thanks already! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a wait step in integration-tests workflow that checks all Docker Compose services are healthy before running store commands. In this PR #1109 I had the issue that OpenSearch integrations tests would sometimes pass sometimes not.
The step waits up to 5 minutes, checking every 5 seconds, for all services to report either "healthy" status or have no healthcheck defined.
I did as many checks as I could on my local macos machine for all services in compose.yaml and at least it works on my machine, but I am not a bash expert, so do not hold back with your reviews 😄