Add attribute to Dummy: dummy_index #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjodah
force-pushed
the
dummy_index
branch
2 times, most recently
from
c24387d to
ae97832
Compare
bjodah
commented
Jul 23, 2025
| @@ -278,10 +278,10 @@ def sympy2symengine(a, raise_error=False): | |||
| """ | |||
| import sympy | |||
| from sympy.core.function import AppliedUndef as sympy_AppliedUndef | |||
| if isinstance(a, sympy.Symbol): | |||
| if isinstance(a, sympy.Dummy): | |||
There was a problem hiding this comment.
Since Dummy is a subclass of Symbol, we need to check for it first.
|
Tests pass (excluding AppVeyor which we should fix separately). This is ready for review. |
|
whenever you feel you have the time for this one @isuruf, no stress. |
isuruf
approved these changes
Aug 4, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-516