Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enhance status line separator configuration #2313

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

PFiS1737
Copy link

@PFiS1737 PFiS1737 commented Feb 10, 2025

Close: #2312

Description

  • Add configurations for status line separator and format
    • sep_left = { open = "", close = "" }
    • sep_right = { open = "", close = "" }
    • format_percent = [ "Top", "%2d%%", "Bot" ]
    • format_position = "%2d/%-2d"
    • format_mode = "%.3s"

Checklist:

  • make another PR to update the docs

@PFiS1737 PFiS1737 closed this Feb 10, 2025
@sxyazi
Copy link
Owner

sxyazi commented Feb 10, 2025

Actually, separator_left and separator_right don't seem to make the theme.toml that much more complicated.

Do you have a screenshot showing what it looks like when different values are set for them?

@PFiS1737
Copy link
Author

Certainly

1

Example

2
3

@sxyazi
Copy link
Owner

sxyazi commented Feb 10, 2025

That looks great, this will be a nice improvement!

Could you make this PR only include the changes for separator_left and separator_right?

@sxyazi sxyazi reopened this Feb 10, 2025
@PFiS1737
Copy link
Author

done

@PFiS1737
Copy link
Author

PFiS1737 commented Feb 10, 2025

I sincerely request you to reconsider whether the formatting-related features can be merged into the main branch. They are not complex and provide convenience for those who want customization. For others, they can simply remain unchanged.

If possible, I will submit another PR. Those changes don’t seem to be breaking.

@PFiS1737 PFiS1737 changed the title feat: enhance status line configuration. feat!: enhance status line separator configuration Feb 10, 2025
@PFiS1737
Copy link
Author

docs update: yazi-rs/yazi-rs.github.io#203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Enhance status line configuration
2 participants