Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize tests and docs #85

Merged
merged 13 commits into from
Feb 9, 2025
Merged

Conversation

hirasso
Copy link
Member

@hirasso hirasso commented Feb 5, 2025

Description

Some things from the recently closed PR #84 that make sense for future development

  • add a test for moving <dialog> fragments to the top layer
  • create files in ./tests/fixtures/dist both before playwright tests as well as before test:e2e:serve
  • update npm dependencies
  • Use <dialog open> elements in all modal overlay examples

Direct link to the new README: https://github.com/swup/fragment-plugin/blob/chore/cleanup-tests-and-docs/README.md

Checks

  • The PR is submitted to the main branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

Copy link

github-actions bot commented Feb 5, 2025

Playwright test results

passed  15 passed

Details

stats  15 tests across 1 suite
duration  
commit  0d73836

@hirasso hirasso force-pushed the chore/cleanup-tests-and-docs branch from 710c782 to f41f6a5 Compare February 5, 2025 12:32
@hirasso hirasso requested a review from daun February 5, 2025 12:36
@hirasso hirasso changed the title chore: cleanup tests and docs chore: optimize tests and docs Feb 9, 2025
@hirasso
Copy link
Member Author

hirasso commented Feb 9, 2025

@daun ready for review I guess :)

@daun
Copy link
Member

daun commented Feb 9, 2025

👌

@hirasso hirasso merged commit 66c326e into master Feb 9, 2025
2 checks passed
@hirasso hirasso deleted the chore/cleanup-tests-and-docs branch February 9, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants