-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAST-303 -- feat: infrastructure for linting and building #5
VAST-303 -- feat: infrastructure for linting and building #5
Conversation
All checks have passed... :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RudolfSchreier covered the most important points already so mostly nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@RudolfSchreier I would like to follow up on this PR. I've completed all the requested changes about two weeks ago and requested a review at that time. I understand we want to maintain a thoughtful pace with PRs, which is why I waited before checking in. Please let me know if you need any additional information from me to help move this forward or if there's anything else I can clarify. Thanks! |
@domcyrus Since we had a reorg since those two weeks passed, I also want to add that I will take a strong step back from active PR reviews in the future, and should not be considered a blocking obstacle if anyone else can add their review instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RudolfSchreier Thanks! |
VAST-303 feat: Infrastructure For Linting And Building
Context
Not part of this PR is whether we should use another bundler than
bun
nor if bundling could happen within the composite action. This can be tackled in a separate PR if needed.Contents
This PR is adding infrastructure for our shared composite github actions in
ast-gh-actions
.Notes (optional)
Deliberatly removed
husky
because it cannot handle monorepo style repos:.husky
typicode/husky#1175