Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAST-303 -- feat: infrastructure for linting and building #5

Merged
merged 10 commits into from
Feb 10, 2025

Conversation

domcyrus
Copy link
Collaborator

VAST-303 feat: Infrastructure For Linting And Building

Context

Not part of this PR is whether we should use another bundler than bun nor if bundling could happen within the composite action. This can be tackled in a separate PR if needed.

Contents

This PR is adding infrastructure for our shared composite github actions in ast-gh-actions.

  • git hook
    • ensure that dist is updated
    • linting
  • checked in configuration files for ESLint and prettier
    • ignore dist for linting
    • documented in README.md
  • github actions
    • linting
    • building and failing if dist doesn't match
  • code owners @swisstxt/accessibility-services

Notes (optional)

Deliberatly removed husky because it cannot handle monorepo style repos:

@domcyrus
Copy link
Collaborator Author

All checks have passed... :)

Copy link
Member

@devnoname120 devnoname120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domcyrus domcyrus requested a review from devnoname120 January 24, 2025 12:58
Copy link
Member

@devnoname120 devnoname120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RudolfSchreier covered the most important points already so mostly nits

Copy link
Member

@devnoname120 devnoname120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@domcyrus domcyrus requested a review from devnoname120 February 4, 2025 13:03
@domcyrus
Copy link
Collaborator Author

@RudolfSchreier I would like to follow up on this PR. I've completed all the requested changes about two weeks ago and requested a review at that time. I understand we want to maintain a thoughtful pace with PRs, which is why I waited before checking in. Please let me know if you need any additional information from me to help move this forward or if there's anything else I can clarify. Thanks!

@RudolfSchreier
Copy link
Contributor

RudolfSchreier commented Feb 10, 2025

@RudolfSchreier I would like to follow up on this PR. I've completed all the requested changes about two weeks ago and requested a review at that time. I understand we want to maintain a thoughtful pace with PRs, which is why I waited before checking in. Please let me know if you need any additional information from me to help move this forward or if there's anything else I can clarify. Thanks!

@domcyrus
0 offense intended, simply slipped down my list of attention.
Since I already added a first review, I will add my re-review here ASAP.

Since we had a reorg since those two weeks passed, I also want to add that I will take a strong step back from active PR reviews in the future, and should not be considered a blocking obstacle if anyone else can add their review instead.

Copy link
Contributor

@RudolfSchreier RudolfSchreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domcyrus
Copy link
Collaborator Author

@RudolfSchreier Thanks!

@domcyrus domcyrus merged commit 7f5b291 into main Feb 10, 2025
4 checks passed
@domcyrus domcyrus deleted the VAST-303-feat-infrastructure-for-linting-and-building branch February 10, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants