Skip to content

Aptos: add to pool (WIP)#460

Merged
nicomiicro merged 12 commits into
aptos/contractsfrom
aptos/add-to-pool
Oct 26, 2022
Merged

Aptos: add to pool (WIP)#460
nicomiicro merged 12 commits into
aptos/contractsfrom
aptos/add-to-pool

Conversation

@nicomiicro

@nicomiicro nicomiicro commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Adds PoolState aptos implementation

Notion ticket: https://www.notion.so/exsphere/Aptos-integration-f6daa06ac05b48f490528c38a50ffd88

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 25, 2022

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c7156f1
Status: ✅  Deploy successful!
Preview URL: https://31eeea3c.swim-ui.pages.dev
Branch Preview URL: https://aptos-add-to-pool.swim-ui.pages.dev

View logs

Comment thread packages/solana/src/client.ts
Comment thread packages/aptos/src/protocol.ts Outdated
Comment thread packages/aptos/src/client.ts Outdated
Comment thread packages/aptos/src/client.ts Outdated
Comment thread packages/aptos/src/client.ts Outdated
Comment thread packages/aptos/src/client.ts Outdated
Comment thread packages/aptos/src/client.ts
Comment thread packages/aptos/src/client.ts
Comment thread packages/aptos/src/client.ts Outdated
Comment thread apps/ui/src/models/swim/pool.ts

@wormat wormat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits.

Comment thread packages/aptos/src/liquidswap/index.ts Outdated
Comment thread packages/aptos/src/liquidswap/utils.ts Outdated
@nicomiicro

Copy link
Copy Markdown
Contributor Author

@wormat how are we going to publish the modules? Merge this one first, publish, then merge again?

@wormat

wormat commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

@nicomiicro I think we just merge this into aptos/contracts without publishing and publish when that branch is ready to merge.

@nicomiicro

Copy link
Copy Markdown
Contributor Author

@wormat ok. That would be ready when "Add to pool" works, right?

@nicomiicro
nicomiicro marked this pull request as ready for review October 26, 2022 09:56
@nicomiicro
nicomiicro merged commit 823318a into aptos/contracts Oct 26, 2022
@nicomiicro
nicomiicro deleted the aptos/add-to-pool branch October 26, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants