UI/wormhole form#453
Open
cyphertrace wants to merge 5 commits into
Open
Conversation
Deploying with
|
| Latest commit: |
f500a9e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://afbb60e0.swim-ui.pages.dev |
| Branch Preview URL: | https://ui-wormhole-form.swim-ui.pages.dev |
cyphertrace
requested review from
nicomiicro,
ramenuncle,
swimthor and
wormat
October 20, 2022 15:40
wormat
force-pushed
the
ui/wormhole-hooks
branch
from
October 20, 2022 17:47
2c59c83 to
dfdb38e
Compare
wormat
force-pushed
the
ui/wormhole-form
branch
from
October 20, 2022 17:52
348ec79 to
6a6f769
Compare
wormat
force-pushed
the
ui/wormhole-hooks
branch
from
October 21, 2022 09:37
eec9295 to
81c5729
Compare
cyphertrace
force-pushed
the
ui/wormhole-form
branch
from
October 21, 2022 10:06
180ee06 to
47eddc6
Compare
wormat
force-pushed
the
ui/wormhole-form
branch
2 times, most recently
from
October 21, 2022 12:54
62c60b7 to
2a63f9b
Compare
wormat
force-pushed
the
ui/wormhole-hooks
branch
from
October 21, 2022 13:00
81c5729 to
5e78fce
Compare
wormat
force-pushed
the
ui/wormhole-form
branch
from
October 21, 2022 13:02
2a63f9b to
39d25d8
Compare
wormat
reviewed
Oct 21, 2022
wormat
reviewed
Oct 24, 2022
| <EuiSpacer /> | ||
| <WormholeForm /> | ||
| </EuiPageContentBody> | ||
| <EuiPageContent |
Collaborator
There was a problem hiding this comment.
Aren't we still supposed to have an EuiPageContentBody?
Contributor
Author
There was a problem hiding this comment.
I don't find necessary that much element wrapping, as we have just form, it makes styling more difficult to handle.
wormat
reviewed
Oct 24, 2022
wormat
reviewed
Oct 25, 2022
wormat
approved these changes
Oct 25, 2022
wormat
left a comment
wormat
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, let's send it to manual testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket: N/A
Checklist