Skip to content

Aptos protocol in UI and first wallet adapter (Martian wallet)#390

Merged
nicomiicro merged 16 commits into
masterfrom
aptos/wallet-adapters
Sep 22, 2022
Merged

Aptos protocol in UI and first wallet adapter (Martian wallet)#390
nicomiicro merged 16 commits into
masterfrom
aptos/wallet-adapters

Conversation

@nicomiicro

@nicomiicro nicomiicro commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

Notion ticket: https://www.notion.so/exsphere/Aptos-integration-f6daa06ac05b48f490528c38a50ffd88

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@nicomiicro nicomiicro changed the title Aptos/wallet adapters Aptos protocol in UI and first wallet adapter (Martian wallet) Sep 20, 2022
@nicomiicro nicomiicro added the feature New feature or request label Sep 20, 2022
@nicomiicro nicomiicro self-assigned this Sep 20, 2022
Comment thread apps/ui/package.json Outdated
Comment thread apps/ui/src/components/MultiWalletModal/MultiWalletModal.tsx
Comment thread apps/ui/src/config/chains.ts
Comment thread packages/aptos/src/walletAdapters/BaseAdapter.ts
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 20, 2022

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: eae87c2
Status: ✅  Deploy successful!
Preview URL: https://2285935d.swim-ui.pages.dev
Branch Preview URL: https://aptos-wallet-adapters.swim-ui.pages.dev

View logs

@nicomiicro nicomiicro requested a review from wormat September 20, 2022 13:15

@wormat wormat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Comment thread packages/aptos/src/ecosystem.ts Outdated
Comment thread packages/aptos/src/walletAdapters/BaseAdapter.ts
Comment thread apps/ui/src/config/ecosystem.ts Outdated
Comment thread packages/aptos/src/ecosystem.ts Outdated
Comment thread packages/aptos/src/walletAdapters/MartianWalletAdapter.ts Outdated
Comment thread packages/aptos/src/walletAdapters/MartianWalletAdapter.ts
Comment thread apps/ui/src/hooks/wallets/tests/useWalletAutoConnect.test.ts Outdated
@nicomiicro nicomiicro requested a review from wormat September 21, 2022 08:13
@nicomiicro

Copy link
Copy Markdown
Contributor Author

@wormat does this need any other change/update?

@wormat wormat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits.

Comment thread packages/aptos/src/walletAdapters/BaseAdapter.ts Outdated
Comment thread apps/ui/src/hooks/wallets/tests/useWalletAutoConnect.test.ts Outdated
@nicomiicro

Copy link
Copy Markdown
Contributor Author

@wormat once this is approved, I will publish packages v0.26.0 for aptos (make it public too) and wormhole changes.

wormat
wormat previously approved these changes Sep 22, 2022

@wormat wormat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Waiting for info from biz about whether this needs to be secret for now before publishing. If it does then I guess we just merge the changes to the private package and add the UI changes later.

@nicomiicro nicomiicro marked this pull request as ready for review September 22, 2022 10:41

@wormat wormat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge pending manual testing.

@github-actions

Copy link
Copy Markdown

✨ Deployment complete! Take a peek over at https://1d246a8d.ui-storybook.pages.dev

@nicomiicro nicomiicro merged commit d39592a into master Sep 22, 2022
@nicomiicro nicomiicro deleted the aptos/wallet-adapters branch September 22, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants