Skip to content

Fix sourcekit-lsp diagnostics counter #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix sourcekit-lsp diagnostics counter #1834

wants to merge 2 commits into from

Conversation

award999
Copy link
Contributor

@award999 award999 commented Sep 16, 2025 •
edited
Loading

Description

  • Fix the regex which only worked for a single digit
  • Make the progress notification increment to show bar fill up

Issue: #1799

Tasks

  • Required tests have been written
  • Documentation has been updated
  • Added an entry to CHANGELOG.md if applicable

@award999 award999 force-pushed the diagnostics-progress branch from d4d1675 to 3772aa4 Compare September 16, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plemarquand plemarquand plemarquand approved these changes

@adam-fowler adam-fowler Awaiting requested review from adam-fowler adam-fowler is a code owner

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@award999 @plemarquand