Partial warning cleanup: remove unused awaits and refactor argument parsing #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced multiple `filter(...).first` calls with a single `compactMap(...).first` to simplify logic and eliminate compiler warnings related to unwrapped optionals and unused bindings. The new implementation is more concise and performs better.
belkhadir
requested review from
shahmishal,
cmcgee1024,
justice-adams-apple and
etcwilde
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a few compiler warnings and includes a small refactor.
Changes
awaitexpressions where no async operations were occurring, resolvingNo 'async' operations occur within 'await' expressionwarningsarg.namesparsing logic to usecompactMap(...).first, replacing repetitivefilter(...).firstchains and eliminating a warningsys.installer(...)with_keywith_infor (key, value)loop