Skip to content

[Windows] Include packaging only when requested #84377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

[Windows] Include packaging only when requested #84377

merged 1 commit into from
Oct 3, 2025

Conversation

bnbarham
Copy link
Contributor

Defaults to -SkipPackaging and removes it if INCLUDE_PACKAGING is set.

@bnbarham bnbarham requested a review from shahmishal September 18, 2025 18:03
@bnbarham bnbarham requested a review from compnerd as a code owner September 18, 2025 18:03
@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test

compnerd
compnerd approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do check that the PR times are not impacted by this!

@bnbarham
Copy link
Contributor Author

Please do check that the PR times are not impacted by this!

Is there more to check than making sure -SkipPackaging is still passed through 🤔?

@bnbarham
Copy link
Contributor Author

And it is:

swift-ci@EC2AMAZ-JCVOGM7 C:\Users\swift-ci\jenkins\workspace\swift-PR-windows>powershell.exe -ExecutionPolicy RemoteSigned -File C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\utils\build.ps1      -SourceCache C:\Users\swift-ci\jenkins\workspace\swift-PR-windows   -BinaryCache T:   -ImageRoot T:   -SkipPackaging       -Test lld,lldb,swift,dispatch,foundation,xctest,swift-format,sourcekit-lsp   -IncludeSBoM   -Summary   || (exit /b 1 )

@shahmishal
Copy link
Member

@swift-ci please build toolchain Windows ARM64

@bnbarham
Copy link
Contributor Author

@swift-ci please build toolchain Windows ARM64

@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/swift-installer-scripts#462

@swift-ci please build toolchain windows platform

@bnbarham
Copy link
Contributor Author

@swift-ci please build toolchain windows platform

@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test

@compnerd
Copy link
Member

@swift-ci please build toolchain Windows platform

1 similar comment
@compnerd
Copy link
Member

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member

‘build/artifacts/’ doesn’t match anything, but ‘’ does. Perhaps that’s what you mean?
ERROR: Step ‘Archive the artifacts’ failed: No artifacts found that match the file pattern "build/artifacts/*". Configuration error?

Seems like we have a staging issue still :(

@compnerd
Copy link
Member

@swift-ci please build toolchain Windows platform

@bnbarham bnbarham merged commit 36286a3 into swiftlang:main Oct 3, 2025
4 of 5 checks passed
@bnbarham bnbarham deleted the swap-packaging branch October 3, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnbarham @shahmishal @compnerd