Skip to content

wasm-run.py: consistent wasmkit path with build_runtime_with_host_compiler #83134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2025
Merged

wasm-run.py: consistent wasmkit path with build_runtime_with_host_compiler #83134

merged 2 commits into from
Jul 18, 2025

Conversation

MaxDesiatov
Copy link
Contributor

When passing --build-runtime-with-host-compiler there's no such executable wasmkit-cli in the host toolchain, where it's named wasmkit when installed. Let's make that consistent to make it work in both cases.

@MaxDesiatov
wasm-run.py: make wasmkit path consistent with `build_runtime_with_…
326c73f 
…host_compiler`

When passing `--build-runtime-with-host-compiler` there's no such executable `wasmkit-cli` in the host toolchain, where it's named `wasmkit` when installed. Let's make that consistent to make it work in both cases.
@MaxDesiatov MaxDesiatov added test suite Area: test suite python Flag: Python source code WebAssembly Platform: WebAssembly WASI WebAssembly System Interface support labels Jul 17, 2025
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test macos

@MaxDesiatov MaxDesiatov marked this pull request as ready for review July 17, 2025 20:38
kateinoigakukun
kateinoigakukun requested changes Jul 18, 2025
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to change wasmkit.py to place the executable in build dir with the updated name as well?

@MaxDesiatov
Copy link
Contributor Author

Don't we need to change wasmkit.py to place the executable in build dir with the updated name as well?

IIUC it still worked on CI because it picked up wasmkit binary from the installation directory, but I agree that having it as wasmkit in the build directory should be better.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

kateinoigakukun
kateinoigakukun approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxDesiatov MaxDesiatov enabled auto-merge July 18, 2025 09:13
@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test macos

@MaxDesiatov MaxDesiatov merged commit 0cd5721 into swiftlang:main Jul 18, 2025
3 checks passed
@MaxDesiatov MaxDesiatov deleted the consistent-wasmkit-path branch July 18, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde is a code owner

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

Assignees
No one assigned
Labels
python Flag: Python source code test suite Area: test suite WASI WebAssembly System Interface support WebAssembly Platform: WebAssembly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @kateinoigakukun