6.2: Build and install Testing and Foundation for Wasm Swift SDK #83059
+146
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 5f2b002, swift-testing is being compiled with WMO, which removes some of inter-object references in object files by DCE. The inter-object reference removal revealed a long-standing issue that the runtime metadata sections of objects in an archive are not always included in the final binary if symbols from those objects are not referenced anywhere. To force including all metadata sections in the final binary, we have to emit everything in a single object file when building the archive. This issue happens only for Wasm SDK, which ships swift-testing as a static archive.
This reverts commit d5abfa4.
MaxDesiatov
changed the title
|
@swift-ci test |
|
@swift-ci build toolchain |
MaxDesiatov
changed the title
MaxDesiatov
added
Foundation
cross-compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #82285, merged as 05204bd
Explanation: Include Swift Testing Foundation and libxml2 into the Swift SDK for WebAssembly
Scope: Limited to Swift SDK for Wasm
Risk: Low, due to limited scope. Changes were incubated on
mainfor 2 weeks with no known issues. Swift Testing changes were incubated for more than a month.Testing: Manual testing with Swift SDKs produced off
main.Issue: rdar://155865189
Reviewer: @MaxDesiatov