AST: Cache isNoncopyable() and isEscapable() bits inside TypeBase #82854
+56
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
approved these changes
Jul 7, 2025
| assert(!canType->hasTypeParameter()); | ||
| assert(!canType->hasUnboundGenericType()); | ||
| assert(!isa<SILBoxType>(canType)); | ||
| assert(!isa<SILMoveOnlyWrappedType>(canType)); |
There was a problem hiding this comment.
Just double-checking: are the prior special cases for SILTokenType and SILPackType no longer needed?
There was a problem hiding this comment.
they are, and the build fails without them. bringing them back :)
slavapestov
force-pushed
the
cache-invertible-conformances
branch
from
942a3b6 to
7bbe6f9
Compare
slavapestov
force-pushed
the
cache-invertible-conformances
branch
from
7bbe6f9 to
b91ed32
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SIL optimizer makes frequent calls to these functions, so I think it makes sense to cache these because checkConformance() is quite expensive.