RequirementMachine: Add more limits to catch runaway computation, and fix a bug #82321
+198
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuzzer found a couple of issues where we were missing termination limits to prevent runaway computation.
Also, we incorrectly accepted this protocol below, and proceeded to prove nonsense about it, because of a book-keeping bug in Knuth-Bendix completion. If two rules overlap at more than one position, we would only resolve the critical pair at the first position. Oops!
In a hypothetical world where this protocol is accepted, all of the same() calls should also be accepted because each equivalence holds under the protocol's same-type requirements. (You can work this out by hand even). Today, we diagnose that the last three calls to same() have mismatched argument types.
The correct behavior is to reject M3 because it doesn't actually have a finite complete presentation over any alphabet: