[6.2][embedded][overlay] _Builtin_float and Synchronization cannot be imported in embedded Swift mode #82117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ian-twilightcoder
commented
Jun 9, 2025
ian-twilightcoder
commented
- Explanation: This change fixes the embedded module build for the _Builtin_float and Synchronization modules so that they can be used with iOS target triples.
- Scope: Embedded Swift using some particular target triples.
- Original PRs: [embedded][overlay] _Builtin_float and Synchronization cannot be imported in embedded Swift mode #82094
- Risk: Risk that the _Builtin_float and Synchronization modules still don't build properly in embedded mode.
- Testing: Tested that the modules now import when building with iOS target triples.
… imported in embedded Swift mode The _Builtin_float and Synchronization modules are getting the SDK_NAME encoded in their embedded modules, preventing them from being used outside of macOS in embedded mode. rdar://152665402
ian-twilightcoder
force-pushed
the
builtin-float-embedded
branch
from
aa971ec to
83577a7
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.