[SIL] RemarkStreamer: Use mangled function names #82110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-stadler
requested review from
eeckstein,
artemcm and
jckarter
as code owners
|
Makes sense to me. @gottesmm does this affect assembly vision error reporting if we do this? |
|
@swift-ci Please test |
|
@swift-ci please test |
|
@swift-ci please test macOS |
jckarter
approved these changes
Jun 10, 2025
tobias-stadler
force-pushed
the
remarks-fix-mangled-functionnames
branch
from
abd02cd to
a5b0ea7
Compare
|
@swift-ci please test |
Remarks emitted by LLVM use the mangled function name. Be consistent with LLVM when serializing SIL remarks, so external tools can properly filter for all remarks attributed to a certain function.
tobias-stadler
force-pushed
the
remarks-fix-mangled-functionnames
branch
from
a5b0ea7 to
4b0c000
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remarks emitted by LLVM use the mangled function name. Be consistent with LLVM when serializing SIL remarks, so external tools can properly filter for all remarks attributed to a certain function.