Skip to content

[6.2][cxx-interop] Support _LIBCPP_PREFERRED_OVERLOAD #82106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

Xazax-hun
Copy link
Contributor

Explanation: Some functions are implemented both in libc and libc++. Clang uses the enable_if attribute to resolve otherwise ambiguous functions calls. This PR makes the name lookup aware of this attribute.
Issue: rdar://152192945
Risk: Low, only C/C++ APIs with enable_if attributes are affected.
Testing: Regression test added.
Original PR: #82019
Reviewer: @hnrklssn

Explanation: Some functions are implemented both in libc and libc++.
Clang uses the enable_if attribute to resolve otherwise ambiguous
functions calls. This PR makes the name lookup aware of this attribute.
Issue: rdar://152192945
Risk: Low, only C/C++ APIs with enable_if attributes are affected.
Testing: Regression test added.
Original PR: #82019
Reviewer: @hnrklssn
@Xazax-hun Xazax-hun requested a review from hnrklssn June 9, 2025 12:45
@Xazax-hun Xazax-hun requested a review from a team as a code owner June 9, 2025 12:45
@Xazax-hun Xazax-hun added c++ interop Feature: Interoperability with C++ 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Jun 9, 2025
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

@Xazax-hun
Copy link
Contributor Author

@swift-ci please test

@Xazax-hun
Copy link
Contributor Author

@swift-ci please test macOS

@devincoughlin devincoughlin merged commit 5c40660 into release/6.2 Jun 12, 2025
5 checks passed
@devincoughlin devincoughlin deleted the gaborh/ambiguous-overloads-on-6.2 branch June 12, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++ 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants