[6.2][cxx-interop] Support _LIBCPP_PREFERRED_OVERLOAD #82106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: Some functions are implemented both in libc and libc++. Clang uses the enable_if attribute to resolve otherwise ambiguous functions calls. This PR makes the name lookup aware of this attribute. Issue: rdar://152192945 Risk: Low, only C/C++ APIs with enable_if attributes are affected. Testing: Regression test added. Original PR: #82019 Reviewer: @hnrklssn
Xazax-hun
added
c++ interop
|
@swift-ci please smoke test |
|
@swift-ci please test |
hnrklssn
approved these changes
Jun 9, 2025
|
@swift-ci please test macOS |
devincoughlin
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Some functions are implemented both in libc and libc++. Clang uses the enable_if attribute to resolve otherwise ambiguous functions calls. This PR makes the name lookup aware of this attribute.
Issue: rdar://152192945
Risk: Low, only C/C++ APIs with enable_if attributes are affected.
Testing: Regression test added.
Original PR: #82019
Reviewer: @hnrklssn