Skip to content

Revert "[Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps #81243" #81658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "[Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps #81243" #81658

wants to merge 1 commit into from
+6 −4

Conversation

qiongsiwu
Copy link
Contributor

This reverts commit 024dbd0, reversing changes made to a08b1cb.

The commit did not solve the fundamental issue we need to handle and is no longer necessary.

rdar://144794793

@qiongsiwu qiongsiwu requested review from artemcm and cyndyishida May 21, 2025 00:01
@qiongsiwu
Copy link
Contributor Author

qiongsiwu commented May 21, 2025 •
edited
Loading

swiftlang/llvm-project#10717
@swift-ci test

@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@qiongsiwu qiongsiwu mentioned this pull request May 21, 2025
Open
@cyndyishida
Copy link
Contributor

Can you update the commit title to say "Revert [Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps"
Otherwise, it's harder to tell from a condensed git log what the commit is doing.

@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci test

@qiongsiwu qiongsiwu changed the title Revert "Merge pull request #81243 from qiongsiwu/eng_144794793" Revert "[Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps #81243" May 21, 2025
@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci test

@qiongsiwu
Copy link
Contributor Author

The previous test failure should be fixed by #81666.

@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@qiongsiwu
Copy link
Contributor Author

swiftlang/llvm-project#10717
@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyndyishida cyndyishida cyndyishida approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

@beccadax beccadax Awaiting requested review from beccadax beccadax is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun is a code owner

@j-hui j-hui Awaiting requested review from j-hui j-hui is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro is a code owner

@artemcm artemcm Awaiting requested review from artemcm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qiongsiwu @cyndyishida