Skip to content

Fix accidentally dropping image encoding quality on the floor on Windows. #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2025
Merged

Fix accidentally dropping image encoding quality on the floor on Windows. #1368

merged 4 commits into from
Oct 16, 2025

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Oct 16, 2025 •
edited
Loading

This fixes a bug in AttachableImageFormat.init(encoderCLSID:encodingQuality:) where the encodingQuality argument would not be preserved.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Fix accidentally dropping image encoding quality on the floor on Wind…
b86ba8a 
…ows.

This fixes a bug in `AttachableImageFormat.init(encoderCLSID:encodingQuality:)`
where the `encodingQuality` argument would not be preserved.
@grynspan grynspan added this to the Swift 6.x (main) milestone Oct 16, 2025
@grynspan grynspan self-assigned this Oct 16, 2025
@grynspan grynspan added the bug 🪲 Something isn't working label Oct 16, 2025
@grynspan grynspan requested a review from jerryjrchen as a code owner October 16, 2025 18:22
@grynspan grynspan added windows 🪟 Windows support attachments/activities 🖇️ Work related to attachments and/or activities image-attachments 📸 Work related to image attachments self-reviewed PR was self-reviewed by a code owner labels Oct 16, 2025
@grynspan
Copy link
Contributor Author

Self-reviewing due to the small size of the change and merging when CI is done.

@grynspan
Copy link
Contributor Author

Paul no! Now I can't self-review. 😢

@grynspan grynspan removed the self-reviewed PR was self-reviewed by a code owner label Oct 16, 2025
@grynspan grynspan merged commit c1be7ba into main Oct 16, 2025
24 checks passed
@grynspan grynspan deleted the jgrynspan/fix-encoding-quality-dropped branch October 16, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plemarquand plemarquand plemarquand approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

@jerryjrchen jerryjrchen Awaiting requested review from jerryjrchen jerryjrchen is a code owner

Assignees

@grynspan grynspan

Labels

attachments/activities 🖇️ Work related to attachments and/or activities bug 🪲 Something isn't working image-attachments 📸 Work related to image attachments windows 🪟 Windows support

Projects

None yet

Milestone

Swift 6.x (main)

Development

Successfully merging this pull request may close these issues.

2 participants

@grynspan @plemarquand