-
Notifications
You must be signed in to change notification settings - Fork 125
Make Attachment always conform to CustomStringConvertible.
#1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
grynspan
merged 2 commits into
main
from
jgrynspan/attachment-always-conform-to-customstringconvertible
Oct 20, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
| // | ||
|
|
||
| #if !hasFeature(Embedded) | ||
| /// A helper protocol for ``boxCopyableValue(_:)``. | ||
| private protocol _CopyablePointer { | ||
| /// Load the value at this address into an existential box. | ||
| /// | ||
| /// - Returns: The value at this address. | ||
| func load() -> Any | ||
| } | ||
|
|
||
| extension UnsafePointer: _CopyablePointer where Pointee: Copyable { | ||
| func load() -> Any { | ||
| pointee | ||
| } | ||
| } | ||
| #endif | ||
|
|
||
| /// Copy a value to an existential box if its type conforms to `Copyable`. | ||
| /// | ||
| /// - Parameters: | ||
| /// - value: The value to copy. | ||
| /// | ||
| /// - Returns: A copy of `value` in an existential box, or `nil` if the type of | ||
| /// `value` does not conform to `Copyable`. | ||
| /// | ||
| /// When using Embedded Swift, this function always returns `nil`. | ||
| #if !hasFeature(Embedded) | ||
| @available(_castingWithNonCopyableGenerics, *) | ||
| func boxCopyableValue(_ value: borrowing some ~Copyable) -> Any? { | ||
| withUnsafePointer(to: value) { address in | ||
| return (address as? any _CopyablePointer)?.load() | ||
grynspan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| #else | ||
| func boxCopyableValue(_ value: borrowing some ~Copyable) -> Void? { | ||
| nil | ||
| } | ||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.