Add missing testTarget for package init swift-testing tests
#9152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `swift package init --type executable --enable-swift-testing` an example test is generated but the test target is not created in the manifest. This applies to the `tool` and `executable` types. Add the missing test target to the manifest when these types are initialized with swift-testing tests. Issue: swiftlang#9149
plemarquand
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test windows |
dschaefer2
approved these changes
Sep 18, 2025
dschaefer2
reviewed
Sep 18, 2025
| """ | ||
| } else { | ||
| testTarget = "" | ||
| } |
There was a problem hiding this comment.
I think this is true now, but just checking that we support tests depending on executables with all our supported platforms? I remember Windows being an issue but I think we fixed that.
There was a problem hiding this comment.
I believe this is true, yes
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When running
swift package init --type executable --enable-swift-testingan example test is generated but the test target is not created in the manifest.Modifications:
Add the missing test target to the manifest when these types are initialized with swift-testing tests. This applies to the
toolandexecutabletypes.Result:
Packages are initialized with a test target and running
swift testruns the generated test successfully.Issue: #9149