Skip to content

[Tests] Consolidate expectThrowsCommandExecutionError usage #9125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Tests] Consolidate expectThrowsCommandExecutionError usage #9125

wants to merge 7 commits into from
+62 −55

Conversation

plemarquand
Copy link
Contributor

  • Add throwing and non-throwing overloads for expectThrowsCommandExecutionError in SwiftTesting+Helpers
  • Remove duplicate implementation from APIDiffTests
  • Simplify call sites by using appropriate overload without unnecessary trys where appropriate

@plemarquand
Test: Consolidate expectThrowsCommandExecutionError usage
0964deb 
- Add throwing and non-throwing overloads for
  expectThrowsCommandExecutionError in SwiftTesting+Helpers
- Remove duplicate implementation from APIDiffTests
- Simplify call sites by using appropriate overload without unnecessary
  `try`s where appropriate
@plemarquand plemarquand mentioned this pull request Sep 10, 2025
Draft
@plemarquand plemarquand changed the title Tests: Consolidate expectThrowsCommandExecutionError usage [Tests] Consolidate expectThrowsCommandExecutionError usage Sep 10, 2025
@plemarquand
Copy link
Contributor Author

@swift-ci test

@plemarquand plemarquand force-pushed the expect-throws-cmd-exec branch from e6d2e0a to e7c1a68 Compare September 14, 2025 19:18
@plemarquand
Copy link
Contributor Author

@swift-ci please test

@plemarquand
Copy link
Contributor Author

@swift-ci test windows

@plemarquand plemarquand enabled auto-merge (squash) September 19, 2025 12:33
@bkhouri
Copy link
Contributor

bkhouri commented Sep 19, 2025

Most of the CI builds last passed 4 days ago. So let's retrigerred the builds to ensure they are still free

@swift-ci test

@bkhouri
Copy link
Contributor

bkhouri commented Sep 19, 2025

The builds failed with

09:04:48  [Pipeline] sh
09:04:48  /Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test@tmp/durable-dc99efd2/script.sh.copy: line 1: unexpected EOF while looking for matching `''
09:04:48  [Pipeline] }

Retriggering the two macOS

@swift-ci test macOS

@bkhouri
Copy link
Contributor

bkhouri commented Sep 19, 2025

The builds failed with

09:04:48  [Pipeline] sh
09:04:48  /Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test@tmp/durable-dc99efd2/script.sh.copy: line 1: unexpected EOF while looking for matching `''
09:04:48  [Pipeline] }

Re-triggering the Swift Test Linux Platform (smoke test), which requires also triggering the Linus self-hosted pipeline too.

@swift-ci test linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkhouri bkhouri bkhouri approved these changes

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plemarquand @bkhouri