Skip to content

fix linker flags for dynamic libraries when executing command plugin #9091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix linker flags for dynamic libraries when executing command plugin #9091

wants to merge 5 commits into from
+172 −1

Conversation

supersonicbyte
Copy link

Add appropriate -tool suffix to linker flags in dynamic libraries when executing swift package command_plugin.

Motivation:

Resolves the following issue: #9062

Modifications:

Add appropriate -tool suffix to linker flags in dynamic libraries when executing swift package command_plugin.

Result:

Executing swift package command_plugin with dynamic dependencies works.

@supersonicbyte
Copy link
Author

@swift-ci test

1 similar comment
@owenv
Copy link
Contributor

owenv commented Sep 5, 2025

@swift-ci test

owenv
owenv approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Could you please add a test to CommandPluginTests in PackageCommandTests.swift that covers this case?

@supersonicbyte
Copy link
Author

lgtm. Could you please add a test to CommandPluginTests in PackageCommandTests.swift that covers this case?

ofc!

@supersonicbyte
Copy link
Author

@owenv added, can you run the CI please?

@owenv
Copy link
Contributor

owenv commented Sep 5, 2025

@swift-ci test

owenv
owenv reviewed Sep 5, 2025
View reviewed changes
Tests/CommandsTests/PackageCommandTests.swift
}
}

@Test(arguments: getBuildData(for: SupportedBuildSystemOnAllPlatforms))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to wrap this in something like this for now to get to a passing CI run:

withKnownIssue {
} when: {
                ProcessInfo.hostOperatingSystem == .windows
                    || (ProcessInfo.hostOperatingSystem == .linux && data.buildSystem == .swiftbuild)
            }

There are some unrelated issues setting up the runtime library paths on linux for plugin executables which I haven't fixed yet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrapped! thanks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owenv can you rerun the CI again, please?

@supersonicbyte
Copy link
Author

@swift-ci test

@hassila
Copy link

hassila commented Sep 8, 2025

Not sure what the proper process is as this affects both Darwin and Linux, but if possible to cherry-pick this for a future 6.2 it would be fantastic as it would unblock the work in progress for ordo-one/package-benchmark#318 - currently there is no way to do that with a plugin without breaking benchmark users CI.

@plemarquand
Copy link
Contributor

@swift-ci test

@plemarquand
Copy link
Contributor

@swift-ci test windows

@supersonicbyte
Copy link
Author

@owenv @plemarquand not sure what's with the windows build?

@owenv
Copy link
Contributor

owenv commented Sep 12, 2025

Sorry, missed this - I think a retry may address it

@swift-ci test Windows

@owenv
Copy link
Contributor

owenv commented Sep 13, 2025

Windows seems to be hitting some repeated infra timeout, which should be unrelated to the change here

@swift-ci please test Windows

@owenv
Copy link
Contributor

owenv commented Sep 14, 2025

latest run

× Test commandPluginDynamicDependencies(buildData:) recorded an issue with 1 argument buildData → BuildData(buildSystem: SPMBuildCore.BuildSystemProvider.Kind.native, config: PackageModel.BuildConfiguration.debug) at PackageCommandTests.swift:7115:38: Known issue was not recorded

looks like the known issue is a little too broad

@supersonicbyte
Copy link
Author

latest run

× Test commandPluginDynamicDependencies(buildData:) recorded an issue with 1 argument buildData → BuildData(buildSystem: SPMBuildCore.BuildSystemProvider.Kind.native, config: PackageModel.BuildConfiguration.debug) at PackageCommandTests.swift:7115:38: Known issue was not recorded

looks like the known issue is a little too broad

removed windows from the known issue, could you run the CI again please?

@owenv
Copy link
Contributor

owenv commented Sep 15, 2025

I suspect this is still going to fail when the host is Windows and buildSystem == .swiftbuild, but let's give it a try in the meantime

@swift-ci test

@supersonicbyte
Copy link
Author

I suspect this is still going to fail when the host is Windows and buildSystem == .swiftbuild, but let's give it a try in the meantime

@swift-ci test

ok, fixed the when condition to:

(ProcessInfo.hostOperatingSystem == .windows && buildData.buildSystem == .swiftbuild) || (ProcessInfo.hostOperatingSystem == .linux && buildData.buildSystem == .swiftbuild)

@supersonicbyte supersonicbyte mentioned this pull request Sep 15, 2025
Open
3 tasks
@owenv
Copy link
Contributor

owenv commented Sep 15, 2025

@swift-ci test

@owenv
Copy link
Contributor

owenv commented Sep 15, 2025

just going to assign this to myself so I don't lose track. Thanks for your patience working through the test issues

@owenv owenv self-assigned this Sep 15, 2025
@owenv
Copy link
Contributor

owenv commented Sep 15, 2025

@swift-ci test Windows

@supersonicbyte
Copy link
Author

just going to assign this to myself so I don't lose track. Thanks for your patience working through the test issues

No problem, thank you for your assistance!

@supersonicbyte
Copy link
Author

The Swift Test Windows Platform seems to be really stubborn.
The latest fail is related to some foundation tests...

Error: Error: swift exited with code 1.
Invocation:
  swift test --scratch-path T:\x86_64-unknown-windows-msvc\FoundationTests --package-path C:\Users\swift-ci\jenkins\workspace\swiftpm-PR-windows\swift-corelibs-foundation -c release -debug-info-format none --multiroot-data-file C:\Users\swift-ci\jenkins\workspace\swiftpm-PR-
....

@owenv
Copy link
Contributor

owenv commented Sep 16, 2025

foundation was broken for a few hours yesterday

@swift-ci test Windows

@owenv owenv enabled auto-merge (squash) September 16, 2025 16:15
@owenv
Copy link
Contributor

owenv commented Sep 17, 2025

@swift-ci test self hosted

1 similar comment
@owenv
Copy link
Contributor

owenv commented Sep 17, 2025

@swift-ci test self hosted

@owenv
Copy link
Contributor

owenv commented Sep 17, 2025

now hitting #9150

@owenv
Copy link
Contributor

owenv commented Sep 18, 2025

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenv owenv owenv approved these changes

@jakepetroules jakepetroules jakepetroules approved these changes

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

Assignees

@owenv owenv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@supersonicbyte @owenv @hassila @plemarquand @jakepetroules