Skip to content

Tests: Migrate Test Command Tests to Swift Testing #8835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Jun 17, 2025

Migrate the Test Command Tests to Swift Testing. Make use of the parameterized tests to reduce duplication and use to get signal when tests have been fixed.

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 17, 2025

@swift-ci test

@bkhouri bkhouri force-pushed the t/convertBuildComment/convert_test-commands-to-swift-testing branch from 5f43df8 to 17f82cb Compare June 18, 2025 16:18
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 18, 2025

@swift-ci test

@bkhouri bkhouri force-pushed the t/convertBuildComment/convert_test-commands-to-swift-testing branch from 17f82cb to 5524f9b Compare June 18, 2025 16:36
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 18, 2025

@swift-ci test

@bkhouri bkhouri force-pushed the t/convertBuildComment/convert_test-commands-to-swift-testing branch from 5524f9b to a99aa08 Compare June 18, 2025 16:42
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 18, 2025

@swift-ci test

@bkhouri bkhouri force-pushed the t/convertBuildComment/convert_test-commands-to-swift-testing branch from a99aa08 to b873fa3 Compare June 18, 2025 16:46
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 18, 2025

@swift-ci test

@@ -59,54 +59,3 @@ extension Trait where Self == Testing.ConditionTrait {
}
}
}

extension Trait where Self == Testing.Bug {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved to SwiftTesting+TraitsBug.swift

bug(nil, id: 0, comment)
}
}
extension Tag {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved, and expanded, to SwiftTesting+Tags.swift

try XCTSkipIf(type(of: self) == TestCommandTestCase.self, "Skipping this test since it will be run in subclasses that will provide different build systems to test.")
}
@Suite(
// .serialized, // to limit the number of swift executable running.
Copy link
Contributor Author

@bkhouri bkhouri Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: consider removing this., or enabling .serialized

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 18, 2025

@swift-ci test windows

Migrate the Test Command Tests to Swift Testing. Make use of the
parameterized tests to reduce duplication and use  to get signal when
tests have been fixed.
@bkhouri bkhouri force-pushed the t/convertBuildComment/convert_test-commands-to-swift-testing branch from b873fa3 to 5d6e011 Compare June 18, 2025 18:15
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 18, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 18, 2025

@swift-ci test windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant