@testable cleanup #8826
Draft
@testable cleanup #8826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
|
@swift-ci please test |
|
@swift-ci test |
|
This change may conflict with #8821 |
|
Yeah, I think that we should just go for this single shot - the changes are all mechanical, but the CI times are quite long. I'm happy to hand off the set if someone wants to help drive merging the full set into the tree split up. |
|
There seem to be a number of failures on Linux: |
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series cleans up the vast majority of the
@testableimporting in the tests. The one that remains is for X509 which is external to this package. I intend to introduce a SPI for that API surface to help remove the last of the@testableimporting.