Tests: Minor tweaks in Swift Build related tests #8473
Conversation
pmattos
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
| } | ||
|
|
||
| override func testDuplicateProductNamesWithNonDefaultLibsThrowError() async throws { | ||
| try await super.testDuplicateProductNamesWithNonDefaultLibsThrowError() |
There was a problem hiding this comment.
Removed all overrides that just call back the corresponding super class method.
There was a problem hiding this comment.
chore (blocking): Please re-add the override as it was needed to ensure the XCTests on linux instantiate all the tests in the subclass.
@cmcgee1024 can provide additional information as to why it was originally added.
There was a problem hiding this comment.
Hmm, wasn't aware of that Linux hack, sorry :-(
So to be clear: all Linux test suites need to override all test cases... and then call super? If so, are we sure we actually did this hack everywhere? For instance BuildPlanSwiftBuildTests has dozen of tests but only two are overridden like this.
CC @cmcgee1024
There was a problem hiding this comment.
from my understanding, only 1 test needs to be overridden to have XCTest "populate" all the tests in the subclass.
|
|
||
| override func testDuplicateProductNamesWithNonDefaultLibsThrowError() async throws { | ||
| try await super.testDuplicateProductNamesWithNonDefaultLibsThrowError() | ||
| final class BuildPlanNativeTests: BuildPlanTestCase { |
There was a problem hiding this comment.
Marked all these subclasses final to make it clear we don't further extend such tests anywhere else.
|
@swift-ci test |
|
@swift-ci test windows |
pmattos
force-pushed
the
pmattos/swift-build-tests-tweaks
branch
from
c6ec569 to
7424110
Compare
|
@swift-ci test |
|
@swift-ci test windows |
pmattos
force-pushed
the
pmattos/swift-build-tests-tweaks
branch
from
7424110 to
32944d8
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test macOS |
1 similar comment
|
@swift-ci test macOS |
| } | ||
|
|
||
| override func testDuplicateProductNamesWithNonDefaultLibsThrowError() async throws { | ||
| try await super.testDuplicateProductNamesWithNonDefaultLibsThrowError() |
There was a problem hiding this comment.
chore (blocking): Please re-add the override as it was needed to ensure the XCTests on linux instantiate all the tests in the subclass.
@cmcgee1024 can provide additional information as to why it was originally added.
| return .native | ||
| } | ||
|
|
||
| override func skipIfApiDigesterUnsupportedOrUnset() throws { |
There was a problem hiding this comment.
chore (blocking): please re-add this override.
| return .swiftbuild | ||
| } | ||
|
|
||
| override func skipIfApiDigesterUnsupportedOrUnset() throws { |
There was a problem hiding this comment.
chore (blocking): please re-add this override.
| return .native | ||
| } | ||
|
|
||
| override func testUsage() async throws { |
There was a problem hiding this comment.
chore (blocking): please re-add this override.
| return .xcode | ||
| } | ||
|
|
||
| override func testUsage() async throws { |
There was a problem hiding this comment.
chore (blocking): please re-add this override.
| return .native | ||
| } | ||
|
|
||
| override func testUsage() async throws { |
There was a problem hiding this comment.
chore (blocking): please re-add this override.
| return .swiftbuild | ||
| } | ||
|
|
||
| override func testUsage() async throws { |
There was a problem hiding this comment.
chore (blocking): please re-add this override.
| return .native | ||
| } | ||
|
|
||
| override func testUsage() async throws { |
There was a problem hiding this comment.
chore (blocking): please re-add this override.
| return .swiftbuild | ||
| } | ||
|
|
||
| override func testUsage() async throws { |
There was a problem hiding this comment.
chore (blocking): please re-add this override.
| return .swiftbuild | ||
| } | ||
|
|
||
| override func testNoParameters() async throws { |
There was a problem hiding this comment.
chore (blocking): please re-add this override to ensure the tests gets "instantiated" on linux when all other tests are "fixed".
Motivation:
This includes some (minor) tweaks I did in Swift Build related tests while working on the much bigger #8454.
Modifications:
Minor improvements to all
BuildSystemProviderTestCasesubclasses. For instance, these tests:Plus some changes to sibling test classes too.
Related to #8454.