[Tests] NFC: Remove overload of GeneralizedTime.init(_:)
#7986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`swift-certificates` now implements initializer that accepts `Date` and doesn't throw which means this method is redundant but also incorrect because overloading only on `throws` is ambiguous in most cases due to throws checking not being part of the expression checking. Uses of this overload type-checked only because it was always preferred before due to old type-checker hacks that we are trying to remove.
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci please test |
MaxDesiatov
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
swift-certificatesnow implements initializer that acceptsDateand doesn't throw which means this method is redundant but also incorrect because overloading only onthrowsis ambiguous in most cases due to throws checking not being part of the expression checking.Uses of this overload type-checked only because it was always preferred before due to old type-checker hacks that we are trying to remove.
Modifications:
GeneralizedTime.init(_:) throwsthat was added beforeswift-certificatesintroduced their own non-throwing version.Result:
No more duplicate code that is less safe than what
swift-certificatesvends.