Change traverseModules to return modules with their dependencies
#7977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci Please test |
xedin
reviewed
Sep 18, 2024
| /// provides the data to the caller by means of `onModule` callback. The products | ||
| /// are completely transparent to this method and are represented by their module dependencies. | ||
| /// Calls `onModule` for every module in the the package with the modules that depend on it. The products are | ||
| /// completely transparent to this method and are represented by their module dependencies. | ||
| package func traverseModules( |
There was a problem hiding this comment.
If you want to filter out all of duplicate spots where a particular module is used then all you need to do is modify depthFirstSearch to not walk into duplicate nodes, this method can stay the same.
There was a problem hiding this comment.
Updated it to check whether we visited a node already in successors.
ahoppen
force-pushed
the
traverse-modules
branch
2 times, most recently
from
ab9e327
to
1407b2a
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
traverse-modules
branch
from
1407b2a
to
497c9fe
Compare
xedin
approved these changes
Sep 19, 2024
Opening the SourceKit-LSP workspace using a debug build of sourcekit-lsp takes about 35s because `traverseModules` generates about 800,000 callback calls. All SourceKit-LSP needs now are the modules and their dependencies, so we can refactor `traverseModules` to visit only node once. With these changes getting all modules and their dependencies only takes ~0.013s. rdar://136107035
ahoppen
force-pushed
the
traverse-modules
branch
from
497c9fe
to
ff4d624
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of swiftlang/sourcekit-lsp#1683
Opening the SourceKit-LSP workspace using a debug build of sourcekit-lsp takes about 35s because
traverseModulesgenerates about 800,000 callback calls. All SourceKit-LSP needs now are the modules and their dependencies, so we can refactortraverseModulesto just return that information avoid visiting the same modules multiple times. With theses changes getting all modules and their dependencies only takes ~0.013s.rdar://136107035