Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plugins to async/await #7864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move plugins to async/await #7864

wants to merge 1 commit into from

Conversation

AndrewHoos
Copy link
Contributor

Move plugins to async/await

Motivation:

Continue the migration from callbacks to async/await
Make progress to Swift 6 compatibility

Modifications:

Move plugin related APIs to async/await

Result:

Simpler more readable Swift code

@AndrewHoos
Copy link
Contributor Author

@swift-ci test

MaxDesiatov
MaxDesiatov approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a typo nit

@MaxDesiatov MaxDesiatov changed the title Move plugins to async/await Move plugins to async/await Aug 7, 2024
@AndrewHoos
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) August 7, 2024 17:57
@AndrewHoos
Copy link
Contributor Author

@swift-ci test

@AndrewHoos
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sambit650 Sambit650 Sambit650 approved these changes

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis francescomikulis is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewHoos @MaxDesiatov @Sambit650