Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase adoption of async in manifest loading code #7724

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Increase adoption of async in manifest loading code #7724

wants to merge 1 commit into from

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jun 27, 2024 •
edited
Loading

FIXME: this needs reentrancy assertions added, since previously blocking code couldn't be reentrant, but now all async functions on Workspace will.

@MaxDesiatov MaxDesiatov mentioned this pull request Jun 28, 2024
Open
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham will be requested when the pull request is marked ready for review bnbarham is a code owner

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules will be requested when the pull request is marked ready for review jakepetroules is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis francescomikulis will be requested when the pull request is marked ready for review francescomikulis is a code owner

@xedin xedin Awaiting requested review from xedin xedin will be requested when the pull request is marked ready for review xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 will be requested when the pull request is marked ready for review dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam will be requested when the pull request is marked ready for review shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca will be requested when the pull request is marked ready for review bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand will be requested when the pull request is marked ready for review plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv will be requested when the pull request is marked ready for review owenv is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
concurrency DO NOT MERGE workspace Package workspace support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MaxDesiatov