Prefix linker flags with -Xlinker #7588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently SwiftPM fowards unsafe flags under linker settings directly to swiftc un-prefixed. These flags should instead be prefixed with -Xlinker, swiftc flags can instead be passed as unsafe flags under Swift settings. This commit updates SwiftPM to prefix unsafe linker flags with -Xlinker if the package the target is part of uses tools version 6.0.
rauhul
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
Open for discussion! |
MaxDesiatov
reviewed
Jun 5, 2024
| @@ -390,7 +390,13 @@ public final class ProductBuildDescription: SPMBuildCore.ProductBuildDescription | |||
| // Other linker flags. | |||
| for target in self.staticTargets { | |||
| let scope = self.buildParameters.createScope(for: target) | |||
| flags += scope.evaluate(.OTHER_LDFLAGS) | |||
| let additionalFlags = scope.evaluate(.OTHER_LDFLAGS) | |||
| // FIXME: this should be based on the target package's tools version | |||
There was a problem hiding this comment.
IIUC our current convention was to base all behavior on root package's tools version? @neonichu do I understand that correctly?
There was a problem hiding this comment.
It depends. Mostly we try to apply the specific package's tools-version, but there are some behaviors that are more far reaching where we look at root packages.
I think for more build related things like this that should be localized to the package itself, looking at the specific package is the most appropriate.
|
Overall makes sense to me, but this needs tests and that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SwiftPM fowards unsafe flags under linker settings directly to swiftc un-prefixed. These flags should instead be prefixed with -Xlinker, swiftc flags can instead be passed as unsafe flags under Swift settings.
This commit updates SwiftPM to prefix unsafe linker flags with -Xlinker if the package the target is part of uses tools version 6.0.