Pass the "available modules" for a target down to Swift commands #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Swift driver can handle it, produce the complete set of modules that are available within a package (either from targets in that package or products of packages it depends on). Provide that set of available modules as a JSON file to the Swift driver so it can reason about modules that are available to the given target. Also provide the package manifest path and the current target name in the package for use by the compiler.
DougGregor
requested review from
bnbarham,
MaxDesiatov,
jakepetroules and
francescomikulis
as code owners
|
@swift-ci please test |
owenv
reviewed
May 20, 2024
| in package: ResolvedPackage | ||
| ) -> AvailableModulesList { | ||
| package.targets.map { target in | ||
| (target.c99name, .target(name: target.name)) |
There was a problem hiding this comment.
I don't think this is guaranteed to be correct for C targets or binary targets, and it should exclude any plugin and macro targets
There was a problem hiding this comment.
For binary targets we at least tell people to match the target name and module name, but we aren't verifying it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Swift driver can handle it, produce the complete set of modules that are available within a package (either from targets in that package or products of packages it depends on). Provide that set of available modules as a JSON file to the Swift driver so it can reason about modules that are available to the given target. Also provide the package manifest path and the current target name in the package for use by the compiler.
This goes along with swiftlang/swift#73745