Fixes some issues with line wrapping around inline code #215
Conversation
- Inline code that would have wrapped at the beginning of a line no longer gets an extra blank line before it. - Punctuation immediately following inline code is no longer pushed to the next line. - A line break is inserted before a symbolic link that would overflow the preferred line length.
|
@swift-ci Please test |
|
@swift-ci Please test |
| let source = """ | ||
| Because options are parsed before arguments, an option that consumes or | ||
| suppresses the `--` terminator can prevent a ``postTerminator`` argument | ||
| array from capturing any input. In particular, the | ||
| ``SingleValueParsingStrategy/unconditional``, | ||
| ``ArrayParsingStrategy/unconditionalSingleValue``, and | ||
| ``ArrayParsingStrategy/remaining`` parsing strategies can all consume | ||
| the terminator as part of their values. | ||
| """ | ||
| let expected = """ | ||
| Because options are parsed before arguments, an option that consumes or | ||
| suppresses the `--` terminator can prevent a ``postTerminator`` argument | ||
| array from capturing any input. In particular, the | ||
| ``SingleValueParsingStrategy/unconditional``, | ||
| ``ArrayParsingStrategy/unconditionalSingleValue``, and | ||
| ``ArrayParsingStrategy/remaining`` parsing strategies can all consume the | ||
| terminator as part of their values. | ||
| """ |
There was a problem hiding this comment.
minor: This example data confused me for a bit because the input was already wrapped almost the same as the expected output (only one word wrapped differently). Because of this, I found it difficult to reason about how this test would have behaved differently without the changes in this PR.
There was a problem hiding this comment.
Thanks! That wrapping change wasn't intended – I'll fix that and change the example data to describe the behavior it's validating. (I wasn't quite sure how to go here since these are fixes for bugs that aren't exposed in the current tests.)
| let source = """ | ||
| Perform an atomic logical AND operation on the value referenced by | ||
| `pointer` and return the original value, applying the specified memory | ||
| ordering. | ||
| """ | ||
| let expected = """ | ||
| Perform an atomic logical AND operation on the value referenced by | ||
| `pointer` and return the original value, applying the specified memory | ||
| ordering. | ||
| """ |
There was a problem hiding this comment.
minor: The input and expected output are identical. Because of this, I find it harder to reason about how this test would have behaved differently without the changes in this PR.
Summary
Dependencies
n/a
Testing
Unit tests include new test cases that validate this functionality.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded