Include optionality in AnyRegexOutput.Element.type #825
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reconstructing the type of a captured element for access through the `AnyRegexOutput.Element.type` API, any optionality is being omitted (e.g. `Int?` is returned as `Int`). This is both observable through that API and results in a bug when accessing part of a match's output through the dynamic member subscript (e.g. `match.1`). In that case, the lack of optionality causes an incorrect calculation of the output tuple member's position, resulting in the wrong member being loaded and returned. This change adds the missing optionality to the type. Fixes swiftlang/swift#83022
natecook1000
force-pushed
the
match-subscript-tuple-element
branch
from
af6a199 to
7443f98
Compare
|
@swift-ci Please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reconstructing the type of a captured element for access through the
AnyRegexOutput.Element.typeAPI, any optionality is being omitted (e.g.Int?is returned asInt). This is both observable through that API and results in a bug when accessing part of a match's output through the dynamic member subscript (e.g.match.1).In that case, the lack of optionality causes an incorrect calculation of the output tuple member's position, resulting in the wrong member being loaded and returned.
This change adds the missing optionality to the type.
Fixes swiftlang/swift#83022. (rdar://155710126)