Benchmarker improvements + more benchmarks#581
Merged
rctcwyvrn merged 13 commits intoswiftlang:mainfrom Jul 15, 2022
Merged
Conversation
Contributor
Author
|
@swift-ci test |
Member
|
@swift-ci please test |
rxwei
reviewed
Jul 15, 2022
| result = measure(benchmark: b, samples: result.samples*2) | ||
| print("N = \(result.samples), median: \(result.median), stdev: \(Time(result.stdev))") | ||
| if result.stdev > Stats.maxAllowedStdev { | ||
| fatalError("Benchmark \(b.name) is too variant") |
Contributor
There was a problem hiding this comment.
Should this print the error instead of trapping the program?
Contributor
Author
There was a problem hiding this comment.
Being too variant generally indicates that the system is running stuff in the background and making the benchmarker variant, so in those cases I thought it would probably best to just stop everything and make the user restart it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking the stuff not waiting for legal approval from #515 and adding some more stuff
Benchmarker improvements
saveandcomparetake file paths like a normal CLI instead of the weirdness it was doing beforeNew benchmarks
(If you saw the bit I had here about the interesting list benchmark results, ignore it. It was just a bug :C)