Use the unversioned subdirectory in the rpath. #1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test. |
3405691582
force-pushed
the
rpath
branch
2 times, most recently
from
05c1342 to
f1cfd0d
Compare
While we use versioned subdirectory triples for Swift module paths, this part of the rpath should be unversioned, if at the very least, for consistency. While we are here, ensure that -z origin is used when linking, which is necessary for ORIGIN processing.
Member
Author
|
@swift-ci please test. |
Member
Author
|
@swift-ci please test Windows platform. |
Member
Author
|
@artemcm I'm hoping to get this in before the 6.3 cut; do you mind reviewing? |
etcwilde
approved these changes
Nov 11, 2025
Member
Author
|
Thank you, all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we use versioned subdirectory triples for Swift module paths, this part of the rpath should be unversioned, if at the very least, for consistency.
While we are here, ensure that -z origin is used when linking, which is necessary for ORIGIN processing.