Skip to content

[Gardening] Resolve deprecated API use warnings and remove stale code #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artemcm merged 6 commits into from
Jul 1, 2025
Merged

[Gardening] Resolve deprecated API use warnings and remove stale code #1892

artemcm merged 6 commits into from
Jul 1, 2025

Conversation

@artemcm
Copy link
Contributor

@artemcm artemcm commented May 8, 2025 •
edited
Loading

  • Deprecate old SwiftScan global scanner diagnostic queries. We have since moved on to per-scan queries and the approach being deprecated here is not safe.
  • Replace occurrences of the deprecated ProcessEnv.vars with ProcessEnv.block
  • Deprecate enablement of explicit modules with an environment variable
  • Resolve warnings about deprecated AbsolutePath initializer
  • Migrate ProcessSet implementation to the driver
  • Cleanup the README.md to remove stale content

@artemcm
Copy link
Contributor Author

artemcm commented May 8, 2025

@swift-ci test

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented May 8, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented May 14, 2025

@swift-ci test

@artemcm artemcm force-pushed the GardenEBM branch 3 times, most recently from c58a5b6 to c61b973 Compare May 14, 2025 19:42
@artemcm
Copy link
Contributor Author

artemcm commented May 14, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented May 14, 2025

@swift-ci test

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented May 30, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 10, 2025

@swift-ci test

@artemcm artemcm force-pushed the GardenEBM branch 2 times, most recently from c1cc289 to f1bb300 Compare June 13, 2025 17:37
@artemcm
Copy link
Contributor Author

artemcm commented Jun 13, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 13, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 13, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 13, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 16, 2025

@swift-ci test Linux platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 16, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 17, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 17, 2025

@swift-ci test Windows platform

artemcm
artemcm commented Jun 17, 2025
View reviewed changes
@artemcm
Copy link
Contributor Author

artemcm commented Jun 17, 2025

@swift-ci test Windows platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Jun 23, 2025

@swift-ci test Windows platform

tshortli
tshortli reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@tshortli tshortli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@artemcm
Copy link
Contributor Author

artemcm commented Jun 26, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 26, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 26, 2025

@swift-ci test Windows platform

2 similar comments
@artemcm
Copy link
Contributor Author

artemcm commented Jun 27, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 27, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 28, 2025

@swift-ci please test Windows

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Jun 30, 2025

@swift-ci please test Windows

@artemcm
Copy link
Contributor Author

artemcm commented Jun 30, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 30, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 30, 2025

@swift-ci test Windows platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Jun 30, 2025

@swift-ci test Windows platform

@artemcm
Migrate 'ProcessSet' implementation to the driver
2805d50 
This type is being deprecated and removed in 'swift-tools-support-core'. Move the implementation to the driver.
Long term, the driver's executors should be re-architected to rely on structured concurrency primitives. In the meantime, absorb this functionality into the driver so that it can be freely removed from STSC.
@artemcm
Copy link
Contributor Author

artemcm commented Jul 1, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jul 1, 2025

@swift-ci test Windows platform

@artemcm artemcm merged commit def5462 into swiftlang:main Jul 1, 2025
3 checks passed
@artemcm artemcm deleted the GardenEBM branch July 1, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tshortli tshortli tshortli left review comments

@owenv owenv owenv approved these changes

@cachemeifyoucan cachemeifyoucan Awaiting requested review from cachemeifyoucan

@xymus xymus Awaiting requested review from xymus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artemcm @owenv @tshortli