Skip to content

[6.2] clone path hierarchy nodes when their parent has a language-specific counterpart #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

[6.2] clone path hierarchy nodes when their parent has a language-specific counterpart #1209

merged 1 commit into from
Apr 29, 2025

Conversation

QuietMisdreavus
Copy link
Contributor

  • Explanation: Creates cloned PathHierarchy nodes when symbols have different symbol representations between interface languages.
  • Scope: Fixes an inconsistency in the hierarchy tree that led to assertions and crashes.
  • Issues: rdar://144862231
  • Original PRs: clone path hierarchy nodes when their parent has a language-specific counterpart #1203
  • Risk: Low. This is new behavior for PathHierarchy, but the addition of new tests ensures that it works as expected.
  • Testing: Automated tests have been added.
  • Reviewers: @d-ronnqvist

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit 5ba3de2 into swiftlang:release/6.2 Apr 29, 2025
2 checks passed
@QuietMisdreavus QuietMisdreavus deleted the 6.2/alternate-parent-variants branch April 29, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuietMisdreavus @franklinsch