Update Node.js & NPM #952
Open
Update Node.js & NPM #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marinaaisa
force-pushed
the
update-node
branch
3 times, most recently
from
c2c82d5 to
19393a9
Compare
|
@swift-ci test |
marinaaisa
force-pushed
the
update-node
branch
7 times, most recently
from
8e0add4 to
83abe23
Compare
marinaaisa
force-pushed
the
update-node
branch
3 times, most recently
from
0e6f08d to
42e07a6
Compare
|
@swift-ci test |
I chose this version of Node because: - Latest LTS stability: It's the most recent Long Term Support version, providing stability and security updates until April 2026, making it ideal for production use. - Maximum compatibility: It's the highest Node.js version that works seamlessly with all existing project dependencies without requiring any dependency upgrades. Update Node.js & NPM to 22.17.0
Since highlight.js 11.6+, the `distributed` keyword is built-in and no custom overrides are needed
Replace wrapper.find with wrapper.findComponent instead since wrapper.find is deprecated
This change fixes the deprecation warning: [Vue warn]: Duplicate keys detected: 'A'. This may cause an update error.
|
@swift-ci test |
|
tree-sitter-vue is not compatible with Node.js 22. The version of tree-sitter that works with Node.js 22 is v0.21.0 or later, as it uses the new Node-API instead of NAN for its Node bindings. Since tree-sitter-vue hasn't been updated to use v0.21.0+, it doesn't work with Node.js 22. Related: rdar://156714814 I opened a separate PR in case we want to delete the tree-sitter-vue dependency, since it doesn't work with Node 22. |
marinaaisa
added a commit
to marinaaisa/swift-docker
that referenced
this pull request
Jul 25, 2025
We need to update the Node version to 22.17.0 for the Swift CI to work in Docc-render, since we are also updating Node in the project. [1] [1] swiftlang/swift-docc-render#952
marinaaisa
added a commit
to marinaaisa/swift-docker
that referenced
this pull request
Jul 25, 2025
We need to update the Node version to 22.17.0 in the Swift CI for Docc-Render, to ensure compatibility with the updated Node version used in the project. [1] [1] swiftlang/swift-docc-render#952
|
Swift CI is failing because it's using Node 14.17.4 instead of Node I opened a PR in Swift Docker to update the Node version in Docker to Fixes: rdar://156708326 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #137038442, if applicable:
Summary
This change updates Node.js to
22.17.0& NPM to10.9.2.I chose 22.17.0 version of Node because it's the latest LTS (Long Term Support) version.
Dependencies
NA
Testing
Steps:
rm -rf node_modules package-lock.jsonnpm installnpm run servenpm run testChecklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded